testing: Make all files use `lexical-binding`
Mainly, add the corresponding cookie, but also add various `require`s
so that the compiler knows which vars should be trated as dynbound.
This does not fix all the warnings, but does try to eliminate
all those about "unused" variables. For the variables truly unused,
the patch usually adds an underscore to their name to silence the warning.
Some of the fixes affect files which already used `lexical-binding`.
Not sure why the test worked before: maybe because the tests were run
without compiling them first (which could cause some of the
missing `require`d packages to be autoloaded before we got to the
problematic code, thus hiding the problem)?
I found some suspicious code, for which I added FIXMEs.
There are also a few changes to the main files.
* lisp/org-protocol.el (org-protocol-check-filename-for-protocol):
Don't call `server-edit` if it's not yet defined. [ Needed to get
the tests to pass. ]
* lisp/ob-core.el (org-babel-temporary-directory)
(org-babel-temporary-stable-directory): Always define (and use nil
if we don't want to create a directory for it). Simplify the code based
on the fact that (defvar V E) only evaluates E if V is not yet `boundp`.
(org-babel-temp-file, org-babel-temp-stable-file)
(org-babel-remove-temporary-directory)
(org-babel-remove-temporary-stable-directory): Adjust accordingly.
* lisp/org.el (org-log-beginning): Add FIXME.
* testing/org-test.el: Require `org` and `org-id`.
(org-id-locations-file): Don't `defconst` it.
(org-test-at-id, org-test-in-example-file, org-test-at-marker)
(org-test-with-temp-text, org-test-with-temp-text-in-file): Move edebug
specs into `declare` (and simplify them).
(org-test-with-tramp-remote-dir--worker): Declare dynbound tramp vars.
(org--compile-when): Fix quoting of `exp`.
(org-test-load): Tweak regexps.
* testing/org-batch-test-init.el: Tweak regexp, remove dead code and
add a FIXME about it.
* testing/lisp/test-ox.el: Require `ox` instead of
erroring out if it's not already loaded. Also require `org-inlinetask`.
(org-test-with-parsed-data): Silence warnings when `info` is not used.
(test-org-export/bind-keyword): Add FIXME.
* testing/lisp/test-ox-publish.el: Require `org-test` and `ox-publish`.
(test-org-publish/resolve-external-link): Expose lambdas to
the compiler. Remove unused var `ids`.
(test-org-publish/get-project-from-filename): Remove unused var `file`.
* testing/lisp/test-org.el: Require `org-macs`, `org`,
`org-inlinetask`, `org-refile`, and `org-agenda`.
(test-org/org-read-date): Declare `org-time-was-given` as dynbound.
(test-org/set-regexps-and-options): Add FIXME.
* testing/lisp/test-org-timer.el: Require `org-timer`.
* testing/lisp/test-org-table.el: Require `ox`.
* testing/lisp/test-org-protocol.el: Require `org-protocol` instead of
erroring out if it's not already loaded. Also require `capture`, and
add missing `provide` statement.
* testing/lisp/test-org-pcomplete.el: Require `org`.
* testing/lisp/test-org-list.el: Require `org-list` and `org`.
* testing/lisp/test-org-lint.el: Require `org-footnote` and `org-lint`.
* testing/lisp/test-org-footnote.el: Require `org-footnote`.
* testing/lisp/test-org-element.el: Require `org-element` instead of
erroring out if it's not already loaded. Also require `org` and
`org-inlinetask`.
* testing/lisp/test-org-duration.el: Require `org-duration`.
* testing/lisp/test-org-datetree.el: Require `org-datetree`.
* testing/lisp/test-org-colview.el: Require `org-colview`,
`org-duration`, and `org-inlinetask`.
* testing/lisp/test-org-clock.el: Require `org-duration` and `org-clock`.
* testing/lisp/test-org-archive.el: Require `org-archive`.
* testing/lisp/test-org-agenda.el
(test-org-agenda/bulk-custom-arg-func): Add FIXME.
* testing/lisp/test-ol.el: Require `ol` and `org-id`.
(test-org-link/store-link): Declare `org-store-link-props` and add FIXME.
* testing/lisp/test-oc.el (test-org-cite/export-capability): Add FIXME.
* testing/lisp/test-ob.el: Require `ob-core`, `org-src`, `ob-ref`,
and `org-table`.
(test-ob/eval-header-argument): Rename `foo` to `test-ob--foo` and
declare it as dynbound.
(test-ob/blocks-with-spaces, test-ob/specific-colnames): Add FIXME.
(test-ob/noweb-expansions-in-cache):
Declare `noweb-expansions-in-cache-var` as dynbound.
* testing/lisp/test-ob-tangle.el: Require `org` and `ob-tangle`.
* testing/lisp/test-ob-shell.el:
* testing/lisp/test-ob-python.el: Require `ob-core`.
* testing/lisp/test-ob-lob.el: Require `ob-lob`.
(temporary-value-for-test): Declare as dynbound.
* testing/lisp/test-ob-plantuml.el: Require `ob-plantuml` instead of
erroring out if it's not already loaded.
* testing/lisp/test-ob-lilypond.el: Require `ob-lilypond` instead of
erroring out if it's not already loaded. Use `with-current-buffer`.
* testing/lisp/test-ob-julia.el: Require `ob-core`.
* testing/lisp/test-ob-java.el (org-babel-temporary-directory):
Remove dead code now that `org-babel-temporary-directory` is always bound.
* testing/lisp/test-ob-exp.el: Require `ob-exp`, `org-src`, and `org-test`.
(ob-exp/evaluate-all-executables-in-order):
Declare `*evaluation-collector*` as dynbound.
* testing/lisp/test-ob-emacs-lisp.el (ob-emacs-lisp/dynamic-lexical-edit)
(ob-emacs-lisp/dynamic-lexical-execute):
Rename dynbound var to `ob-emacs--x` and declare it as such.
* testing/lisp/test-ob-R.el: Require `ob-core`.
(ess-ask-for-ess-directory, ess-history-file): Declare vars.
2022-09-14 17:21:37 -04:00
;;; test-ob-octave.el --- tests for ob-octave.el -*- lexical-binding: t; -*-
2011-11-08 16:19:04 -05:00
2019-01-01 05:50:56 -05:00
;; Copyright (c) 2010-2014, 2019 Sergey Litvinov
2011-11-08 16:19:04 -05:00
;; Authors: Sergey Litvinov
2012-12-13 11:24:19 -05:00
;; This file is not part of GNU Emacs.
;; This program is free software; you can redistribute it and/or modify
;; it under the terms of the GNU General Public License as published by
;; the Free Software Foundation, either version 3 of the License, or
;; (at your option) any later version.
;; This program is distributed in the hope that it will be useful,
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
;; GNU General Public License for more details.
;; You should have received a copy of the GNU General Public License
2021-03-20 03:27:57 -04:00
;; along with this program. If not, see <https://www.gnu.org/licenses/>.
2012-12-13 11:24:19 -05:00
2011-11-08 16:19:04 -05:00
( org-test-for-executable " octave " )
2012-03-19 16:38:12 -04:00
( unless ( featurep 'ob-octave )
( signal 'missing-test-dependency " Support for Octave code blocks " ) )
2011-11-08 16:19:04 -05:00
( ert-deftest ob-octave/input-none ( )
" Number output "
( org-test-at-id " 54dcd61d-cf6c-4d7a-b9e5-854953c8a753 "
( org-babel-next-src-block )
( should ( = 10 ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/output-vector ( )
" Vector output "
( org-test-at-id " 54dcd61d-cf6c-4d7a-b9e5-854953c8a753 "
( org-babel-next-src-block 2 )
( should ( equal ' ( ( 1 2 3 4 ) ) ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/input-variable ( )
" Input variable "
( org-test-at-id " cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba "
( org-babel-next-src-block )
( should ( = 42 ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/input-array ( )
" Input an array "
( org-test-at-id " cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba "
( org-babel-next-src-block 2 )
( should ( equal ' ( ( 1 2 3 ) ) ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/input-matrix ( )
" Input a matrix "
( org-test-at-id " cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba "
( org-babel-next-src-block 3 )
( should ( equal ' ( ( 1 2 ) ( 3 4 ) ) ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/input-string ( )
" Input a string "
( org-test-at-id " cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba "
( org-babel-next-src-block 4 )
( should ( equal " te " ( org-babel-execute-src-block ) ) ) ) )
( ert-deftest ob-octave/input-nil ( )
" Input elisp nil "
( org-test-at-id " cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba "
( org-babel-next-src-block 5 )
( should ( equal nil ( org-babel-execute-src-block ) ) ) ) )
2022-03-15 12:33:52 -04:00
2022-11-08 14:31:47 -05:00
( ert-deftest ob-octave/graphics-file ( )
" Graphics file. Test that link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects. "
;; In case a prior test left the Error Output buffer hanging around.
2022-12-21 06:52:44 -05:00
( skip-unless nil ) ; FIXME: Failing on CI only
2022-11-08 14:31:47 -05:00
( when ( get-buffer " *Org-Babel Error Output* " )
( kill-buffer " *Org-Babel Error Output* " ) )
( let ( ( file ( make-temp-file " test-ob-octave- " nil " .png " ) ) )
( unwind-protect
( org-test-with-temp-text
( format " #+begin_src octave :results file graphics :file %s
sombrero ;
# +end_src "
file )
( org-babel-execute-src-block )
( should ( search-forward ( format " [[file:%s]] " file ) nil nil ) )
( should ( file-readable-p file ) )
( should ( > ( file-attribute-size ( file-attributes file ) ) 0 ) )
( should-not ( get-buffer " *Org-Babel Error Output* " ) ) )
;; clean-up
( delete-file file )
( when ( get-buffer " *Org-Babel Error Output* " )
( kill-buffer " *Org-Babel Error Output* " ) ) ) ) )
( ert-deftest ob-octave/graphics-file-session ( )
" Graphics file in a session. Test that session is started in *Inferior Octave* buffer, link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects. "
2022-12-21 06:52:44 -05:00
( skip-unless nil ) ; FIXME: Failing on CI only
2022-11-08 14:31:47 -05:00
( let ( ( file ( make-temp-file " test-ob-octave- " nil " .png " ) ) )
( unwind-protect
( org-test-with-temp-text
( format " #+begin_src octave :session :results file graphics :file %s
crash_dumps_octave_core ( 0 ) ;
sombrero ;
# +end_src "
file )
( org-babel-execute-src-block )
( should ( get-buffer " *Inferior Octave* " ) )
( should ( search-forward ( format " [[file:%s]] " file ) nil nil ) )
( should ( file-readable-p file ) )
( should ( > ( file-attribute-size ( file-attributes file ) ) 0 ) )
( should-not ( get-buffer " *Org-Babel Error Output* " ) ) )
;; clean-up
( delete-file file )
( let ( kill-buffer-query-functions kill-buffer-hook )
( kill-buffer " *Inferior Octave* " ) )
( when ( get-buffer " *Org-Babel Error Output* " )
( kill-buffer " *Org-Babel Error Output* " ) ) ) ) )
( ert-deftest ob-octave/graphics-file-space ( )
" Graphics file with a space in filename. Test that session is started in *Inferior Octave* buffer, link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects. "
2022-12-21 06:52:44 -05:00
( skip-unless nil ) ; FIXME: Failing on CI only
2022-11-08 14:31:47 -05:00
( let ( ( file ( make-temp-file " test ob octave- " nil " .png " ) ) )
( unwind-protect
( org-test-with-temp-text
( format " #+begin_src octave :results file graphics :file %s
sombrero ;
# +end_src "
file )
( org-babel-execute-src-block )
( should ( search-forward ( format " [[file:%s]] " file ) nil nil ) )
( should ( file-readable-p file ) )
( should ( > ( file-attribute-size ( file-attributes file ) ) 0 ) )
( should-not ( get-buffer " *Org-Babel Error Output* " ) ) )
;; clean-up
( delete-file file )
( when ( get-buffer " *Org-Babel Error Output* " )
( kill-buffer " *Org-Babel Error Output* " ) ) ) ) )
2022-03-15 12:33:52 -04:00
( provide 'test-ob-octave )