testing: Make all files use `lexical-binding`
Mainly, add the corresponding cookie, but also add various `require`s
so that the compiler knows which vars should be trated as dynbound.
This does not fix all the warnings, but does try to eliminate
all those about "unused" variables. For the variables truly unused,
the patch usually adds an underscore to their name to silence the warning.
Some of the fixes affect files which already used `lexical-binding`.
Not sure why the test worked before: maybe because the tests were run
without compiling them first (which could cause some of the
missing `require`d packages to be autoloaded before we got to the
problematic code, thus hiding the problem)?
I found some suspicious code, for which I added FIXMEs.
There are also a few changes to the main files.
* lisp/org-protocol.el (org-protocol-check-filename-for-protocol):
Don't call `server-edit` if it's not yet defined. [ Needed to get
the tests to pass. ]
* lisp/ob-core.el (org-babel-temporary-directory)
(org-babel-temporary-stable-directory): Always define (and use nil
if we don't want to create a directory for it). Simplify the code based
on the fact that (defvar V E) only evaluates E if V is not yet `boundp`.
(org-babel-temp-file, org-babel-temp-stable-file)
(org-babel-remove-temporary-directory)
(org-babel-remove-temporary-stable-directory): Adjust accordingly.
* lisp/org.el (org-log-beginning): Add FIXME.
* testing/org-test.el: Require `org` and `org-id`.
(org-id-locations-file): Don't `defconst` it.
(org-test-at-id, org-test-in-example-file, org-test-at-marker)
(org-test-with-temp-text, org-test-with-temp-text-in-file): Move edebug
specs into `declare` (and simplify them).
(org-test-with-tramp-remote-dir--worker): Declare dynbound tramp vars.
(org--compile-when): Fix quoting of `exp`.
(org-test-load): Tweak regexps.
* testing/org-batch-test-init.el: Tweak regexp, remove dead code and
add a FIXME about it.
* testing/lisp/test-ox.el: Require `ox` instead of
erroring out if it's not already loaded. Also require `org-inlinetask`.
(org-test-with-parsed-data): Silence warnings when `info` is not used.
(test-org-export/bind-keyword): Add FIXME.
* testing/lisp/test-ox-publish.el: Require `org-test` and `ox-publish`.
(test-org-publish/resolve-external-link): Expose lambdas to
the compiler. Remove unused var `ids`.
(test-org-publish/get-project-from-filename): Remove unused var `file`.
* testing/lisp/test-org.el: Require `org-macs`, `org`,
`org-inlinetask`, `org-refile`, and `org-agenda`.
(test-org/org-read-date): Declare `org-time-was-given` as dynbound.
(test-org/set-regexps-and-options): Add FIXME.
* testing/lisp/test-org-timer.el: Require `org-timer`.
* testing/lisp/test-org-table.el: Require `ox`.
* testing/lisp/test-org-protocol.el: Require `org-protocol` instead of
erroring out if it's not already loaded. Also require `capture`, and
add missing `provide` statement.
* testing/lisp/test-org-pcomplete.el: Require `org`.
* testing/lisp/test-org-list.el: Require `org-list` and `org`.
* testing/lisp/test-org-lint.el: Require `org-footnote` and `org-lint`.
* testing/lisp/test-org-footnote.el: Require `org-footnote`.
* testing/lisp/test-org-element.el: Require `org-element` instead of
erroring out if it's not already loaded. Also require `org` and
`org-inlinetask`.
* testing/lisp/test-org-duration.el: Require `org-duration`.
* testing/lisp/test-org-datetree.el: Require `org-datetree`.
* testing/lisp/test-org-colview.el: Require `org-colview`,
`org-duration`, and `org-inlinetask`.
* testing/lisp/test-org-clock.el: Require `org-duration` and `org-clock`.
* testing/lisp/test-org-archive.el: Require `org-archive`.
* testing/lisp/test-org-agenda.el
(test-org-agenda/bulk-custom-arg-func): Add FIXME.
* testing/lisp/test-ol.el: Require `ol` and `org-id`.
(test-org-link/store-link): Declare `org-store-link-props` and add FIXME.
* testing/lisp/test-oc.el (test-org-cite/export-capability): Add FIXME.
* testing/lisp/test-ob.el: Require `ob-core`, `org-src`, `ob-ref`,
and `org-table`.
(test-ob/eval-header-argument): Rename `foo` to `test-ob--foo` and
declare it as dynbound.
(test-ob/blocks-with-spaces, test-ob/specific-colnames): Add FIXME.
(test-ob/noweb-expansions-in-cache):
Declare `noweb-expansions-in-cache-var` as dynbound.
* testing/lisp/test-ob-tangle.el: Require `org` and `ob-tangle`.
* testing/lisp/test-ob-shell.el:
* testing/lisp/test-ob-python.el: Require `ob-core`.
* testing/lisp/test-ob-lob.el: Require `ob-lob`.
(temporary-value-for-test): Declare as dynbound.
* testing/lisp/test-ob-plantuml.el: Require `ob-plantuml` instead of
erroring out if it's not already loaded.
* testing/lisp/test-ob-lilypond.el: Require `ob-lilypond` instead of
erroring out if it's not already loaded. Use `with-current-buffer`.
* testing/lisp/test-ob-julia.el: Require `ob-core`.
* testing/lisp/test-ob-java.el (org-babel-temporary-directory):
Remove dead code now that `org-babel-temporary-directory` is always bound.
* testing/lisp/test-ob-exp.el: Require `ob-exp`, `org-src`, and `org-test`.
(ob-exp/evaluate-all-executables-in-order):
Declare `*evaluation-collector*` as dynbound.
* testing/lisp/test-ob-emacs-lisp.el (ob-emacs-lisp/dynamic-lexical-edit)
(ob-emacs-lisp/dynamic-lexical-execute):
Rename dynbound var to `ob-emacs--x` and declare it as such.
* testing/lisp/test-ob-R.el: Require `ob-core`.
(ess-ask-for-ess-directory, ess-history-file): Declare vars.
2022-09-14 17:21:37 -04:00
|
|
|
|
;;; test-org-pcomplete.el --- test pcomplete integration -*- lexical-binding: t; -*-
|
2015-12-29 05:20:09 -05:00
|
|
|
|
|
2019-01-01 05:50:56 -05:00
|
|
|
|
;; Copyright (C) 2015-2016, 2019 Alexey Lebedeff
|
2015-12-29 05:20:09 -05:00
|
|
|
|
;; Authors: Alexey Lebedeff
|
|
|
|
|
|
|
|
|
|
;; This file is not part of GNU Emacs.
|
|
|
|
|
|
|
|
|
|
;; This program is free software; you can redistribute it and/or modify
|
|
|
|
|
;; it under the terms of the GNU General Public License as published by
|
|
|
|
|
;; the Free Software Foundation, either version 3 of the License, or
|
|
|
|
|
;; (at your option) any later version.
|
|
|
|
|
|
|
|
|
|
;; This program is distributed in the hope that it will be useful,
|
|
|
|
|
;; but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
|
|
|
;; GNU General Public License for more details.
|
|
|
|
|
|
|
|
|
|
;; You should have received a copy of the GNU General Public License
|
2021-03-20 03:27:57 -04:00
|
|
|
|
;; along with this program. If not, see <https://www.gnu.org/licenses/>.
|
2015-12-29 05:20:09 -05:00
|
|
|
|
|
|
|
|
|
;;; Comments:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
;;; Code:
|
|
|
|
|
|
testing: Make all files use `lexical-binding`
Mainly, add the corresponding cookie, but also add various `require`s
so that the compiler knows which vars should be trated as dynbound.
This does not fix all the warnings, but does try to eliminate
all those about "unused" variables. For the variables truly unused,
the patch usually adds an underscore to their name to silence the warning.
Some of the fixes affect files which already used `lexical-binding`.
Not sure why the test worked before: maybe because the tests were run
without compiling them first (which could cause some of the
missing `require`d packages to be autoloaded before we got to the
problematic code, thus hiding the problem)?
I found some suspicious code, for which I added FIXMEs.
There are also a few changes to the main files.
* lisp/org-protocol.el (org-protocol-check-filename-for-protocol):
Don't call `server-edit` if it's not yet defined. [ Needed to get
the tests to pass. ]
* lisp/ob-core.el (org-babel-temporary-directory)
(org-babel-temporary-stable-directory): Always define (and use nil
if we don't want to create a directory for it). Simplify the code based
on the fact that (defvar V E) only evaluates E if V is not yet `boundp`.
(org-babel-temp-file, org-babel-temp-stable-file)
(org-babel-remove-temporary-directory)
(org-babel-remove-temporary-stable-directory): Adjust accordingly.
* lisp/org.el (org-log-beginning): Add FIXME.
* testing/org-test.el: Require `org` and `org-id`.
(org-id-locations-file): Don't `defconst` it.
(org-test-at-id, org-test-in-example-file, org-test-at-marker)
(org-test-with-temp-text, org-test-with-temp-text-in-file): Move edebug
specs into `declare` (and simplify them).
(org-test-with-tramp-remote-dir--worker): Declare dynbound tramp vars.
(org--compile-when): Fix quoting of `exp`.
(org-test-load): Tweak regexps.
* testing/org-batch-test-init.el: Tweak regexp, remove dead code and
add a FIXME about it.
* testing/lisp/test-ox.el: Require `ox` instead of
erroring out if it's not already loaded. Also require `org-inlinetask`.
(org-test-with-parsed-data): Silence warnings when `info` is not used.
(test-org-export/bind-keyword): Add FIXME.
* testing/lisp/test-ox-publish.el: Require `org-test` and `ox-publish`.
(test-org-publish/resolve-external-link): Expose lambdas to
the compiler. Remove unused var `ids`.
(test-org-publish/get-project-from-filename): Remove unused var `file`.
* testing/lisp/test-org.el: Require `org-macs`, `org`,
`org-inlinetask`, `org-refile`, and `org-agenda`.
(test-org/org-read-date): Declare `org-time-was-given` as dynbound.
(test-org/set-regexps-and-options): Add FIXME.
* testing/lisp/test-org-timer.el: Require `org-timer`.
* testing/lisp/test-org-table.el: Require `ox`.
* testing/lisp/test-org-protocol.el: Require `org-protocol` instead of
erroring out if it's not already loaded. Also require `capture`, and
add missing `provide` statement.
* testing/lisp/test-org-pcomplete.el: Require `org`.
* testing/lisp/test-org-list.el: Require `org-list` and `org`.
* testing/lisp/test-org-lint.el: Require `org-footnote` and `org-lint`.
* testing/lisp/test-org-footnote.el: Require `org-footnote`.
* testing/lisp/test-org-element.el: Require `org-element` instead of
erroring out if it's not already loaded. Also require `org` and
`org-inlinetask`.
* testing/lisp/test-org-duration.el: Require `org-duration`.
* testing/lisp/test-org-datetree.el: Require `org-datetree`.
* testing/lisp/test-org-colview.el: Require `org-colview`,
`org-duration`, and `org-inlinetask`.
* testing/lisp/test-org-clock.el: Require `org-duration` and `org-clock`.
* testing/lisp/test-org-archive.el: Require `org-archive`.
* testing/lisp/test-org-agenda.el
(test-org-agenda/bulk-custom-arg-func): Add FIXME.
* testing/lisp/test-ol.el: Require `ol` and `org-id`.
(test-org-link/store-link): Declare `org-store-link-props` and add FIXME.
* testing/lisp/test-oc.el (test-org-cite/export-capability): Add FIXME.
* testing/lisp/test-ob.el: Require `ob-core`, `org-src`, `ob-ref`,
and `org-table`.
(test-ob/eval-header-argument): Rename `foo` to `test-ob--foo` and
declare it as dynbound.
(test-ob/blocks-with-spaces, test-ob/specific-colnames): Add FIXME.
(test-ob/noweb-expansions-in-cache):
Declare `noweb-expansions-in-cache-var` as dynbound.
* testing/lisp/test-ob-tangle.el: Require `org` and `ob-tangle`.
* testing/lisp/test-ob-shell.el:
* testing/lisp/test-ob-python.el: Require `ob-core`.
* testing/lisp/test-ob-lob.el: Require `ob-lob`.
(temporary-value-for-test): Declare as dynbound.
* testing/lisp/test-ob-plantuml.el: Require `ob-plantuml` instead of
erroring out if it's not already loaded.
* testing/lisp/test-ob-lilypond.el: Require `ob-lilypond` instead of
erroring out if it's not already loaded. Use `with-current-buffer`.
* testing/lisp/test-ob-julia.el: Require `ob-core`.
* testing/lisp/test-ob-java.el (org-babel-temporary-directory):
Remove dead code now that `org-babel-temporary-directory` is always bound.
* testing/lisp/test-ob-exp.el: Require `ob-exp`, `org-src`, and `org-test`.
(ob-exp/evaluate-all-executables-in-order):
Declare `*evaluation-collector*` as dynbound.
* testing/lisp/test-ob-emacs-lisp.el (ob-emacs-lisp/dynamic-lexical-edit)
(ob-emacs-lisp/dynamic-lexical-execute):
Rename dynbound var to `ob-emacs--x` and declare it as such.
* testing/lisp/test-ob-R.el: Require `ob-core`.
(ess-ask-for-ess-directory, ess-history-file): Declare vars.
2022-09-14 17:21:37 -04:00
|
|
|
|
(require 'org)
|
|
|
|
|
|
2018-10-18 09:49:48 -04:00
|
|
|
|
(ert-deftest test-org-pcomplete/clocktable ()
|
|
|
|
|
"Test completion of clock table parameters."
|
2015-12-29 05:20:09 -05:00
|
|
|
|
(should
|
2018-10-18 09:49:48 -04:00
|
|
|
|
(equal "#+begin: clocktable :scope"
|
|
|
|
|
(org-test-with-temp-text "#+begin: clocktable :sco<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
|
|
|
|
(ert-deftest test-org-pcomplete/drawer ()
|
|
|
|
|
"Test drawer completion."
|
|
|
|
|
(should
|
|
|
|
|
(equal "* Foo\n:PROPERTIES:"
|
|
|
|
|
(org-test-with-temp-text "* Foo\n:<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
(should
|
|
|
|
|
(equal ":DRAWER:\nContents\n:END:\n* Foo\n:DRAWER:"
|
|
|
|
|
(org-test-with-temp-text ":DRAWER:\nContents\n:END:\n* Foo\n:D<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
|
|
|
|
(ert-deftest test-org-pcomplete/entity ()
|
|
|
|
|
"Test entity completion."
|
|
|
|
|
(should
|
|
|
|
|
(equal "\\alpha"
|
|
|
|
|
(org-test-with-temp-text "\\alp<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
(should
|
|
|
|
|
(equal "\\frac12"
|
|
|
|
|
(org-test-with-temp-text "\\frac1<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
2015-12-29 05:20:09 -05:00
|
|
|
|
|
2016-01-02 07:21:39 -05:00
|
|
|
|
(ert-deftest test-org-pcomplete/keyword ()
|
|
|
|
|
"Test keyword and block completion."
|
|
|
|
|
(should
|
2017-02-13 11:14:38 -05:00
|
|
|
|
(string-prefix-p
|
2016-01-02 07:21:39 -05:00
|
|
|
|
"#+startup: "
|
|
|
|
|
(org-test-with-temp-text "#+start<point>"
|
|
|
|
|
(pcomplete)
|
2017-02-13 11:14:38 -05:00
|
|
|
|
(buffer-string))
|
|
|
|
|
t))
|
2016-01-02 07:21:39 -05:00
|
|
|
|
(should
|
2017-02-13 11:14:38 -05:00
|
|
|
|
(string-prefix-p
|
2016-01-02 07:21:39 -05:00
|
|
|
|
"#+begin_center"
|
|
|
|
|
(org-test-with-temp-text "#+begin_ce<point>"
|
|
|
|
|
(pcomplete)
|
2017-02-13 11:14:38 -05:00
|
|
|
|
(buffer-string))
|
|
|
|
|
t)))
|
2016-01-02 07:21:39 -05:00
|
|
|
|
|
2020-05-12 09:44:04 -04:00
|
|
|
|
(ert-deftest test-org-pcomplete/src-block ()
|
|
|
|
|
"Test Babel source block header arguments completion."
|
|
|
|
|
(should
|
|
|
|
|
(string-prefix-p
|
|
|
|
|
"#+begin_src emacs-lisp"
|
|
|
|
|
(org-test-with-temp-text "#+begin_src emac<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
(should
|
|
|
|
|
(string-prefix-p
|
|
|
|
|
"#+begin_src emacs-lisp :session"
|
|
|
|
|
(org-test-with-temp-text "#+begin_src emacs-lisp :sess<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
2018-10-18 09:49:48 -04:00
|
|
|
|
(ert-deftest test-org-pcomplete/link ()
|
|
|
|
|
"Test link completion"
|
|
|
|
|
(should
|
|
|
|
|
(equal "[[org:"
|
|
|
|
|
(org-test-with-temp-text "[[o<point>"
|
|
|
|
|
(let ((org-link-abbrev-alist '(("org" . "https://orgmode.org/"))))
|
|
|
|
|
(pcomplete))
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
(should-not
|
|
|
|
|
(equal "[org:"
|
|
|
|
|
(org-test-with-temp-text "[[o<point>"
|
|
|
|
|
(let ((org-link-abbrev-alist '(("org" . "https://orgmode.org/"))))
|
|
|
|
|
(pcomplete))
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
|
|
|
|
(ert-deftest test-org-pcomplete/prop ()
|
|
|
|
|
"Test property completion."
|
|
|
|
|
(should
|
|
|
|
|
(equal
|
|
|
|
|
"
|
|
|
|
|
* a
|
|
|
|
|
:PROPERTIES:
|
|
|
|
|
:pname:\s
|
|
|
|
|
:END:
|
|
|
|
|
* b
|
|
|
|
|
:PROPERTIES:
|
|
|
|
|
:pname: pvalue
|
|
|
|
|
:END:
|
|
|
|
|
"
|
|
|
|
|
(org-test-with-temp-text "
|
|
|
|
|
* a
|
|
|
|
|
:PROPERTIES:
|
|
|
|
|
:pna<point>
|
|
|
|
|
:END:
|
|
|
|
|
* b
|
|
|
|
|
:PROPERTIES:
|
|
|
|
|
:pname: pvalue
|
|
|
|
|
:END:
|
|
|
|
|
"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
|
|
|
|
(ert-deftest test-org-pcomplete/search-heading ()
|
|
|
|
|
"Test search heading completion."
|
|
|
|
|
(should
|
|
|
|
|
(equal "* Foo\n[[*Foo"
|
|
|
|
|
(org-test-with-temp-text "* Foo\n[[*<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
2018-11-24 20:01:41 -05:00
|
|
|
|
(ert-deftest test-org-pcomplete/tag ()
|
|
|
|
|
"Test tag completion."
|
|
|
|
|
;; Complete at end of line, according to `org-current-tag-alist'.
|
|
|
|
|
(should
|
|
|
|
|
(equal "* H :foo:"
|
|
|
|
|
(org-test-with-temp-text "* H :<point>"
|
|
|
|
|
(let ((org-current-tag-alist '(("foo")))) (pcomplete))
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
(should
|
|
|
|
|
(equal "* H :foo:bar:"
|
|
|
|
|
(org-test-with-temp-text "* H :foo:b<point>"
|
|
|
|
|
(let ((org-current-tag-alist '(("bar")))) (pcomplete))
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
;; If `org-current-tag-alist' is non-nil, complete against tags in
|
|
|
|
|
;; buffer.
|
|
|
|
|
(should
|
|
|
|
|
(equal "* H1 :bar:\n* H2 :bar:"
|
|
|
|
|
(org-test-with-temp-text "* H1 :bar:\n* H2 :<point>"
|
|
|
|
|
(let ((org-current-tag-alist nil)) (pcomplete))
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
;; Do not complete in the middle of a line.
|
|
|
|
|
(should
|
|
|
|
|
(equal "* H :notag: :real:tags:"
|
|
|
|
|
(org-test-with-temp-text "* H :notag:<point> :real:tags:"
|
|
|
|
|
(let ((org-current-tag-alist '(("foo")))) (pcomplete))
|
|
|
|
|
(buffer-string))))
|
|
|
|
|
;; Complete even when there's a match on the line.
|
|
|
|
|
(should
|
|
|
|
|
(equal "* foo: :foo:"
|
|
|
|
|
(org-test-with-temp-text "* foo: :<point>"
|
|
|
|
|
(let ((org-current-tag-alist '(("foo")))) (pcomplete))
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
2018-10-18 09:49:48 -04:00
|
|
|
|
(ert-deftest test-org-pcomplete/todo ()
|
|
|
|
|
"Test TODO completion."
|
|
|
|
|
(should
|
|
|
|
|
(equal "* TODO"
|
|
|
|
|
(org-test-with-temp-text "* T<point>"
|
|
|
|
|
(pcomplete)
|
|
|
|
|
(buffer-string)))))
|
|
|
|
|
|
2015-12-29 05:20:09 -05:00
|
|
|
|
(provide 'test-org-pcomplete)
|
|
|
|
|
;;; test-org-pcomplete.el ends here
|