From 0007df863d94fef911bf10c86cb35e7a08a0e519 Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Thu, 14 Mar 2019 18:11:00 +0100 Subject: [PATCH] org-lint: Do not warn about URL setup files * lisp/org-lint.el (org-lint-non-existent-setupfile-parameter): Do not warn when setup file is a URL. * testing/lisp/test-org-lint.el (test-org-lint/non-existent-setupfile-parameter): Add test. Reported-by: Dominik Schrempf --- lisp/org-lint.el | 9 +++++---- testing/lisp/test-org-lint.el | 3 +++ 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/lisp/org-lint.el b/lisp/org-lint.el index 55dab34c4..95cbb8dc2 100644 --- a/lisp/org-lint.el +++ b/lisp/org-lint.el @@ -574,12 +574,13 @@ Use :header-args: instead" (lambda (k) (when (equal (org-element-property :key k) "SETUPFILE") (let ((file (org-unbracket-string - "\"" "\"" - (org-element-property :value k)))) - (and (not (file-remote-p file)) + "\"" "\"" + (org-element-property :value k)))) + (and (not (org-file-url-p file)) + (not (file-remote-p file)) (not (file-exists-p file)) (list (org-element-property :begin k) - (format "Non-existent setup file \"%s\"" file)))))))) + (format "Non-existent setup file %S" file)))))))) (defun org-lint-wrong-include-link-parameter (ast) (org-element-map ast 'keyword diff --git a/testing/lisp/test-org-lint.el b/testing/lisp/test-org-lint.el index b3ebe8c7e..d96808a92 100644 --- a/testing/lisp/test-org-lint.el +++ b/testing/lisp/test-org-lint.el @@ -240,6 +240,9 @@ This is not a node property "Test `org-lint-non-existent-setupfile-parameter' checker." (should (org-test-with-temp-text "#+setupfile: Idonotexist.org" + (org-lint '(non-existent-setupfile-parameter)))) + (should-not + (org-test-with-temp-text "#+setupfile: https://I.do/not.exist.org" (org-lint '(non-existent-setupfile-parameter))))) (ert-deftest test-org-lint/wrong-include-link-parameter ()