org-export: Suppress some byte-compiling warnings

contrib/lisp/org-export.el

@@ -1116,8 +1116,7 @@ Return options as a plist."
 	    (plist-put
 	     plist :title
 	     (org-element-parse-secondary-string
-	      prop
-	      (cdr (assq 'keyword org-element-string-restrictions))))))
+	      prop (org-element-restriction 'keyword)))))
     (when (setq prop (org-entry-get (point) "EXPORT_TEXT"))
       (setq plist (plist-put plist :text prop)))
     (when (setq prop (org-entry-get (point) "EXPORT_AUTHOR"))
@@ -1489,7 +1488,8 @@ associated numbering \(in the shape of a list of numbers\)."
   "Return list of elements and objects to ignore during export.
 DATA is the parse tree to traverse.  OPTIONS is the plist holding
 export options."
-  (let (ignore
+  (let* (ignore
+	 walk-data			; for byte-compiler.
 	 (walk-data
 	  (function
 	   (lambda (data options selected)
@@ -1498,7 +1498,8 @@ export options."
 	      (lambda (el)
 		(if (org-export--skip-p el options selected) (push el ignore)
 		  (let ((type (org-element-type el)))
-		   (if (and (eq (plist-get info :with-archived-trees) 'headline)
+		    (if (and (eq (plist-get options :with-archived-trees)
+				 'headline)
 			     (eq (org-element-type el) 'headline)
 			     (org-element-property :archivedp el))
 			;; If headline is archived but tree below has
@@ -1518,7 +1519,8 @@ export options."
   "Return list of headlines containing a select tag in their tree.
 DATA is parsed data as returned by `org-element-parse-buffer'.
 INFO is a plist holding export options."
-  (let (selected-trees
+  (let* (selected-trees
+	 walk-data			; for byte-compiler.
 	 (walk-data
 	  (function
 	   (lambda (data genealogy)
@@ -2367,6 +2369,9 @@ of subtree at point.
 When optional argument PUB-DIR is set, use it as the publishing
 directory.
 
+When optional argument VISIBLE-ONLY is non-nil, don't export
+contents of hidden elements.
+
 Return file name as a string, or nil if it couldn't be
 determined."
   (let ((base-name
@@ -2376,8 +2381,7 @@ determined."
 	  (or (and subtreep
 		   (org-entry-get
 		    (save-excursion
-		      (ignore-errors
-			(org-back-to-heading (not visible-only)) (point)))
+		      (ignore-errors (org-back-to-heading) (point)))
 		    "EXPORT_FILE_NAME" t))
 	      ;; File name may be extracted from buffer's associated
 	      ;; file, if any.
@@ -2639,7 +2643,8 @@ INFO is the plist used as a communication channel.
 Definitions are sorted by order of references.  They either
 appear as Org data or as a secondary string for inlined
 footnotes.  Unreferenced definitions are ignored."
-  (let (num-alist
+  (let* (num-alist
+	 collect-fn			; for byte-compiler.
 	 (collect-fn
 	  (function
 	   (lambda (data)
@@ -2673,7 +2678,8 @@ INFO is the plist used as a communication channel."
     (if (not label) t
       ;; Otherwise, return the first footnote with the same LABEL and
       ;; test if it is equal to FOOTNOTE-REFERENCE.
-      (let ((search-refs
+      (let* (search-refs		; for byte-compiler.
+	     (search-refs
 	      (function
 	       (lambda (data)
 		 (org-element-map
@@ -2707,8 +2713,9 @@ INFO is the plist used as a communication channel."
 
 FOOTNOTE is either a footnote reference or a footnote definition.
 INFO is the plist used as a communication channel."
-  (let ((label (org-element-property :label footnote))
+  (let* ((label (org-element-property :label footnote))
 	 seen-refs
+	 search-ref			; for byte-compiler.
 	 (search-ref
 	  (function
 	   (lambda (data)
@@ -2893,12 +2900,16 @@ This only applies to links without a description."
   (and (not (org-element-contents link))
        (let ((case-fold-search t)
 	     (rules (or rules org-export-default-inline-image-rule)))
-	 (some
+	 (catch 'exit
+	   (mapc
 	    (lambda (rule)
 	      (and (string= (org-element-property :type link) (car rule))
 		   (string-match (cdr rule)
-			       (org-element-property :path link))))
-	  rules))))
+				 (org-element-property :path link))
+		   (throw 'exit t)))
+	    rules)
+	   ;; Return nil if no rule matched.
+	   nil))))
 
 (defun org-export-resolve-coderef (ref info)
   "Resolve a code reference REF.
@@ -3856,6 +3867,7 @@ BLOB is the element or object being considered.  INFO is a plist
 used as a communication channel."
   (let* ((type (org-element-type blob))
 	 (end (org-element-property :end blob))
+	 walk-data			; for byte-compiler.
          (walk-data
           (lambda (data genealogy)
 	    ;; Walk DATA, looking for BLOB.  GENEALOGY is the list of