From 361fa80ebac966c1789b67b14fcfe550e45dfc62 Mon Sep 17 00:00:00 2001 From: Yasushi SHOJI Date: Tue, 31 May 2016 16:25:42 +0900 Subject: [PATCH 1/2] Fix tag width calculation for multi-column chars MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * lisp/org.el (org-align-tags-here): Fix tag width calculation for multi-column chars. Some characters have multiple column width. Calculating string width with points gives a wrong value than actual display width. Use `string-width' instead. Here is an ECM for this problem. `M-x org-update-statistics-cookies` or `C-c #` on bar moves the tag on the headline. * foo [0/0] :abc: ** child * bar [0/0] :日本語: ** child 12345678901234567890123456789012345678901234567890123456789012345678901234567890 1 2 3 4 5 6 7 8 --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index a9412eaf8..15f851d23 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -14923,7 +14923,7 @@ If ONOFF is `on' or `off', don't toggle but set to this state." (if (and (looking-at (org-re ".*?\\([ \t]+\\)\\(:[[:alnum:]_@#%:]+:\\)[ \t]*$")) (< pos (match-beginning 2))) (progn - (setq tags-l (- (match-end 2) (match-beginning 2))) + (setq tags-l (string-width (match-string 2))) (goto-char (match-beginning 1)) (insert " ") (delete-region (point) (1+ (match-beginning 2))) From 5111c3a5fa0dcc7bacb065270d87a03bde4888b5 Mon Sep 17 00:00:00 2001 From: Yasushi SHOJI Date: Tue, 31 May 2016 16:25:42 +0900 Subject: [PATCH 2/2] Add tests for tag width calculation * testing/lisp/test-org.el (test-org/tag-align): New test. --- testing/lisp/test-org.el | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index db7e5257a..4873fc2f4 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -4131,6 +4131,28 @@ Paragraph" (org-test-with-temp-text "* H\nA\n* H2\nA" (org-occur "A" nil (lambda () (equal (org-get-heading) "H2"))))))) + +;;; Tags + +(ert-deftest test-org/tag-align () + "Test `org-align-tags-here' with different display width." + (should + ;; 12345678901234567890 + (equal "* Test :abc:" + (org-test-with-temp-text "* Test :abc:" + (let ((org-tags-column -20) + (indent-tabs-mode nil)) + (org-fix-tags-on-the-fly)) + (buffer-string)))) + (should + ;; 12345678901234567890 + (equal "* Test :日本語:" + (org-test-with-temp-text "* Test :日本語:" + (let ((org-tags-column -20) + (indent-tabs-mode nil)) + (org-fix-tags-on-the-fly)) + (buffer-string))))) + ;;; Timestamps API